Repository navigation
Milab 7197 add filtered inputs - #15
Merged
Merged
Conversation
Comment on lines
+219
to
+226
| readsBuilder = pframes.tableBuilder("tsv").setColumnJoin("left") | ||
| readsBuilder.setAxisHeader(sampleAxisSpec.name, "sampleId") | ||
| readsBuilder.setAxisHeader(variantAxisSpec.name, "variantKey") | ||
| readsBuilder.addPrimary("main", { | ||
| __isPrimaryRef: "v1", | ||
| column: columns.getColumn("main"), | ||
| filter: filterColumn | ||
| }, { header: "reads" }) |
There was a problem hiding this comment.
The new filtered export path has no regression test. The only block test checks expect(true).toBe(true), so it never exercises addPrimary with a filter. Dropped sample metadata or excluded reads reaching the analysis could go unnoticed.
Add a test with selected and excluded variants. Check that reads.tsv contains only selected variants and keeps their condition and gate values. Also check the unfiltered path.
Prompt To Fix With AI
This is a comment left during a code review.
Path: workflow/src/main.tpl.tengo
Line: 219-226
Comment:
**Filtered export has no tests**
The new filtered export path has no regression test. The only block test checks `expect(true).toBe(true)`, so it never exercises `addPrimary` with a filter. Dropped sample metadata or excluded reads reaching the analysis could go unnoticed.
Add a test with selected and excluded variants. Check that `reads.tsv` contains only selected variants and keeps their condition and gate values. Also check the unfiltered path.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
julenmendieta
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR appears safe to merge, with a non-blocking request to test the new filtered export.
Fix with agent prompt
Summary
Adds an optional subset alongside the dataset selection. The workflow filters reads before scoring and marks result columns with the subset's identity.
Important touched types:
BlockDatafilterReffor the chosen subset column.BlockArgsinputFilter, containing the subset column's canonical ID.DatasetOptionDatasetSelectionPlDatasetSelectorto the saved abundance and filter references.PlReffilterRef.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR Picker[Dataset picker] --> Dataset[Abundance column] Picker --> Filter[Optional subset column] Dataset --> Export[Export reads] Filter --> Export Metadata[Sample metadata] --> Export Export --> Score[Score selected reads] Score --> Results[Build result columns] Filter --> Identity[Subset domain and trace] Identity --> ResultsReviews (1) · Last reviewed commit: "MILAB-7197: forward only the filter's tr..." · Reviewed by Greptile